Fix STRIKE and HIDE ANSI codes #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks! Can you please remove the commits related to the other PR so I can squash-merge this one? |
Delgan
reviewed
Aug 19, 2023
loguru/_colorizer.py
Outdated
| @@ -10,8 +10,8 @@ class Style: | |||
| UNDERLINE = 4 | |||
| BLINK = 5 | |||
| REVERSE = 7 | |||
| STRIKE = 8 | |||
| HIDE = 9 | |||
| STRIKE = 9 | |||
There was a problem hiding this comment.
Can you please swap the order of HIDE and STRIKE so that the list stays sorted?
There was a problem hiding this comment.
Sure, I'll do that within a few days.
|
I rebased your branch before the merge. Thanks for the fix @tunaflsh! |
jmctune
referenced
this pull request
in dqx-translation-project/dqxclarity
Oct 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [loguru](https://github.com/Delgan/loguru) ([changelog](https://github.com/Delgan/loguru/blob/master/CHANGELOG.rst)) | `==0.7.0` -> `==0.7.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Delgan/loguru (loguru)</summary> ### [`v0.7.2`](https://github.com/Delgan/loguru/blob/HEAD/CHANGELOG.rst#072-2023-09-11) [Compare Source](https://github.com/Delgan/loguru/compare/0.7.1...0.7.2) \===================== - Add support for formatting of `ExceptionGroup` errors (`#​805 <https://github.com/Delgan/loguru/issues/805>`\_). - Fix possible `RuntimeError` when using `multiprocessing.set_start_method()` after importing the `logger` (`#​974 <https://github.com/Delgan/loguru/issues/974>`\_) - Fix formatting of possible `__notes__` attached to an `Exception` (`#​980 <https://github.com/Delgan/loguru/issues/980>`\_). ### [`v0.7.1`](https://github.com/Delgan/loguru/blob/HEAD/CHANGELOG.rst#071-2023-09-04) [Compare Source](https://github.com/Delgan/loguru/compare/0.7.0...0.7.1) \===================== - Add a new `context` optional argument to `logger.add()` specifying `multiprocessing` context (like `"spawn"` or `"fork"`) to be used internally instead of the default one (`#​851 <https://github.com/Delgan/loguru/issues/851>`\_). - Add support for true colors on Windows using ANSI/VT console when available (`#​934 <https://github.com/Delgan/loguru/issues/934>`*, thanks `@tunaflsh <https://github.com/tunaflsh>`*). - Fix possible deadlock when calling `logger.complete()` with concurrent logging of an asynchronous sink (`#​906 <https://github.com/Delgan/loguru/issues/906>`\_). - Fix file possibly rotating too early or too late when re-starting an application around midnight (`#​894 <https://github.com/Delgan/loguru/issues/894>`\_). - Fix inverted `"<hide>"` and `"<strike>"` color tags (`#​943 <https://github.com/Delgan/loguru/pull/943>`*, thanks `@tunaflsh <https://github.com/tunaflsh>`*). - Fix possible untraceable errors raised when logging non-unpicklable `Exception` instances while using `enqueue=True` (`#​329 <https://github.com/Delgan/loguru/issues/329>`\_). - Fix possible errors raised when logging non-picklable `Exception` instances while using `enqueue=True` (`#​342 <https://github.com/Delgan/loguru/issues/342>`*, thanks `@ncoudene <https://github.com/ncoudene>`*). - Fix missing seconds and microseconds when formatting timezone offset that requires such accuracy (`#​961 <https://github.com/Delgan/loguru/issues/961>`\_). - Raise `ValueError` if an attempt to use nanosecond precision for time formatting is detected (`#​855 <https://github.com/Delgan/loguru/issues/855>`\_). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dqx-translation-project/dqxclarity). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ANSI codes for STRIKE and HIDE are incorrect. According to ANSI Escape Codes
STRIKEshould be9andHIDEshould be8.