Restructure playground #81
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of changes are attempted in this restructure. The primary goal was to create a separation between the SingularitySandbox and CondaInstall classes which were tightly coupled. The following are done to accomplish this:
Additionally, I noticed a few anti-patterns that are fixed to some extend.
-- Note, It becomes quite confusing which object decides what should be logged, such as
_display_messageinCondaInstallwhich does one thing in tests, but possibly another thing in production as far as I can see. (This should probably be absorbed completely into the log_dispatcher... )A bunch of tests are disabled, although almost only tests with hardcoded monkeypatch behavior. (And the 80 unit width CLI tests, which break when pytest is executed in emacs terminal).
The core functionality CLI commands currently works, including building a container with a conda environment.