This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Makes only one comment for all potentially outdated review comments#79
Merged
Makes only one comment for all potentially outdated review comments#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core diff:
{ "tag": "pinging-reviewers", "status": "🔔 @RReverser - please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-0f40f4-3aba5ac", - "status": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" - }, - { - "tag": "stale-ping-9f0d93-0e6e7f4", - "status": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" + "tag": "stale-ping-764528-0e6e7f4", + "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], "shouldClose": false, "shouldMerge": falseLooking at microsoft/TypeScript#38979 you see a lot of pinging, basically it would look to every stale review, which over the course of a single PR could be many from the same person. The bot currently would re-ping for every potentially stale review.
Instead now it does one ping with all potential reviewers for all stale reviews, de-duped.