[mapbox__mapbox-gl-draw] compatibility with MapBox GL js 3.5+ native types

[brookjordan]

This allows map.on to work correctly with, and updates deprecated types from, the new natively typed mapbox-gl

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@brookjordan Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

• mapbox__mapbox-gl-draw — on npm, on unpkg
  • owner-approval: @tudorgergely
  • 1 added owner: ✎@brookjordan

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 70144,
  "author": "brookjordan",
  "headCommitOid": "e664ec50f91b41c9b35e7d5999b5d41df1cb20a9",
  "mergeBaseOid": "178c0cdae8e88a48e01be8437175cc014b0be473",
  "lastPushDate": "2024-07-26T06:34:46.000Z",
  "lastActivityDate": "2024-07-30T15:26:23.000Z",
  "mergeOfferDate": "2024-07-30T15:11:42.000Z",
  "mergeRequestDate": "2024-07-30T15:26:23.000Z",
  "mergeRequestUser": "brookjordan",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "mapbox__mapbox-gl-draw",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__mapbox-gl-draw/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mapbox__mapbox-gl-draw/mapbox__mapbox-gl-draw-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mapbox__mapbox-gl-draw/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "tudorgergely",
        "Shayan-To",
        "joel-daros"
      ],
      "addedOwners": [
        "brookjordan"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "tudorgergely",
      "date": "2024-07-30T15:11:05.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2252071773,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @tudorgergely @Shayan-To @joel-daros — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@brookjordan The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

[brookjordan]

Pull request made to unblock this:
microsoft/DefinitelyTyped-tools#1038

[brookjordan]

How do I rerun the checks now that mapbox-gl has been whitelisted?

[joel-daros]

How do I rerun the checks now that mapbox-gl has been whitelisted?

Try to send a small change to this PR to trigger the pipeline again.

[typescript-bot]

@brookjordan The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

[brookjordan]

Ready to merge

[neodescis]

This change appears to be causing TypeScript errors for me. I'm now seeing the following:

TS2315: Type 'Map$1' is not generic.

node_modules/mapbox-gl/dist/mapbox-gl.d.ts:1696:21:
1696 │ type ConfigOptions = Map<string, ConfigOptionValue>;

It appears that the declaration of Map in the "mapbox-gl" module in this set of type declarations is conflicting with mapbox's usage of the native Map in its own type declarations.