Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JSDOM types to 21.x #64121

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 28, 2023

21.x did not change any JSDOM APIs. Only changes to its DOM implementation which isn't typed here (lib.dom.d.ts makes no assumptions about the particular implementation).

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 28, 2023

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64121,
  "author": "eps1lon",
  "headCommitOid": "ae5f723a29fe79a7bf15052429494d303de2ba6b",
  "mergeBaseOid": "4ef3d4e49b46e9832fc93208d14ddd249c8360e7",
  "lastPushDate": "2023-01-28T09:22:53.000Z",
  "lastActivityDate": "2023-02-06T08:47:38.000Z",
  "mergeOfferDate": "2023-02-03T20:37:27.000Z",
  "mergeRequestDate": "2023-02-06T08:47:38.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jsdom",
      "kind": "edit",
      "files": [
        {
          "path": "types/jsdom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "palmfjord",
        "ExE-Boss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2023-02-03T20:36:44.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1407352810,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Jan 28, 2023
@typescript-bot
Copy link
Contributor

Hey @eps1lon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @leonard-thieu @palmfjord @ExE-Boss — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 3, 2023
@typescript-bot
Copy link
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at ae5f723) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@leonard-thieu, @palmfjord, @ExE-Boss: you can do this too.)

@eps1lon
Copy link
Collaborator Author

eps1lon commented Feb 6, 2023

Ready to merge

@typescript-bot typescript-bot merged commit f67ea4d into DefinitelyTyped:master Feb 6, 2023
@eps1lon eps1lon deleted the feat/jsdom-21 branch June 10, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants