Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom fixes 2019 07 11 #36837

Merged
merged 4 commits into from
Jul 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions types/jquery/jquery-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ function JQueryStatic() {
target;
});
const myDocForced: JQuery<Document> = $(document);
const myWindow = $(window);
// $ExpectType JQuery<Window>
myWindow;
const myWindowForced: JQuery<Window> = $(window);
// $ExpectType JQuery<Window>
myWindowForced;
Expand Down
3 changes: 1 addition & 2 deletions types/jquery/test/jquery-slim-window-module-tests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import jq = require('jquery/dist/jquery.slim');

const $window = jq(window);
// $ExpectType JQuery<Window>
$window;
const forced: JQuery<Window> = $window;
3 changes: 1 addition & 2 deletions types/jquery/test/jquery-window-module-tests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import jq = require('jquery');

const $window = jq(window);
// $ExpectType JQuery<Window>
$window;
const forced: JQuery<Window> = $window;
73 changes: 32 additions & 41 deletions types/webappsec-credential-management/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Type definitions for non-npm package W3C (WebAppSec) Credential Management API Level 1, 0.4
// Type definitions for non-npm package W3C (WebAppSec) Credential Management API Level 1, 0.5
// Project: https://github.com/w3c/webappsec-credential-management
// Definitions by: Iain McGinniss <https://github.com/iainmcgin>
// Joao Peixoto <https://github.com/Hartimer>
Expand Down Expand Up @@ -124,7 +124,7 @@ interface CredentialData {
* The credential’s identifier. This might be a GUID, username, or email
* address, for instance.
*/
id: string;
readonly id: string;
}

type CredentialType = PasswordCredential|FederatedCredential|PublicKeyCredential;
Expand All @@ -134,13 +134,12 @@ type CredentialType = PasswordCredential|FederatedCredential|PublicKeyCredential
* will inherit.
* @see {@link https://www.w3.org/TR/credential-management-1/#credential}
*/
declare abstract class CredentialBase {
interface Credential {
/**
* The credential’s identifier. This might be a GUID, username, or email
* address, for instance.
*/
readonly id: string;

/**
* The credential’s type.
*/
Expand Down Expand Up @@ -170,7 +169,9 @@ interface SiteBoundCredentialData extends CredentialData {
* agent’s credential
* store.
*/
declare abstract class SiteBoundCredential extends CredentialBase {
// tslint:disable-next-line no-empty-interface
interface SiteBoundCredential extends Credential { }
declare abstract class SiteBoundCredential {
/**
* A name associated with the credential, intended as a human-understandable
* public name.
Expand Down Expand Up @@ -372,16 +373,21 @@ interface FederatedCredentialRequestOptions {

// Type definitions for webauthn
// Spec: https://w3c.github.io/webauthn/
interface txAuthGenericArg {
content: ArrayBuffer;
contentType: string;
}

/**
* @see {@link https://w3c.github.io/webauthn/#enumdef-publickeycredentialtype}
*/
type PublicKeyCredentialType = "public-key";

/**
* @see {@link https://w3c.github.io/webauthn/#enumdef-userverificationrequirement}
*/
type UserVerificationRequirement = "required" | "preferred" | "discouraged";
interface AuthenticationExtensionsClientInputs {
appid?: string;
authnSel?: Array<ArrayBufferView | ArrayBuffer>;
exts?: boolean;
loc?: boolean;
txAuthGeneric?: txAuthGenericArg;
txAuthSimple?: string;
uvi?: boolean;
uvm?: boolean;
}

/**
* @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialrequestoptions}
Expand All @@ -391,8 +397,8 @@ interface PublicKeyCredentialRequestOptions {
timeout?: number;
rpId?: string;
allowCredentials?: PublicKeyCredentialDescriptor[];
userVerification?: UserVerificationRequirement;
extensions?: any;
userVerification?: "required" | "preferred" | "discouraged";
extensions?: AuthenticationExtensionsClientInputs;
}

/**
Expand All @@ -416,43 +422,28 @@ interface PublicKeyCredentialUserEntity {
* @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialparameters}
*/
interface PublicKeyCredentialParameters {
type: PublicKeyCredentialType;
type: "public-key";
alg: number;
}

/**
* @see {@link https://w3c.github.io/webauthn/#transport}
*/
type AuthenticatorTransport = "usb" | "nfc" | "ble" | "internal";

/**
* @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialdescriptor}
*/
interface PublicKeyCredentialDescriptor {
type: PublicKeyCredentialType;
type: "public-key";
id: BufferSource;
transports?: AuthenticatorTransport[];
transports?: Array<"usb" | "nfc" | "ble" | "internal">;
}

/**
* @see {@link https://w3c.github.io/webauthn/#attachment}
*/
type AuthenticatorAttachment = "platform" | "cross-platform";

/**
* @see {@link https://w3c.github.io/webauthn/#dictdef-authenticatorselectioncriteria}
*/
interface AuthenticatorSelectionCriteria {
authenticatorAttachment?: AuthenticatorAttachment;
authenticatorAttachment?: "platform" | "cross-platform";
requireResidentKey?: boolean;
userVerification?: UserVerificationRequirement;
userVerification?: "required" | "preferred" | "discouraged";
}

/**
* @see {@link https://w3c.github.io/webauthn/#attestation-convey}
*/
type AttestationConveyancePreference = "none" | "indirect" | "direct";

/**
* @see {@link https://w3c.github.io/webauthn/#dictdef-makepublickeycredentialoptions}
*/
Expand All @@ -466,8 +457,8 @@ interface PublicKeyCredentialCreationOptions {
timeout?: number;
excludeCredentials?: PublicKeyCredentialDescriptor[];
authenticatorSelection?: AuthenticatorSelectionCriteria;
attestation?: AttestationConveyancePreference;
extensions?: any;
attestation?: "none" | "indirect" | "direct";
extensions?: AuthenticationExtensionsClientInputs;
}

/**
Expand Down Expand Up @@ -496,8 +487,8 @@ interface AuthenticatorAssertionResponse extends AuthenticatorResponse {
/**
* @see {@link https://w3c.github.io/webauthn/#publickeycredential}
*/
interface PublicKeyCredential extends CredentialData {
readonly type: PublicKeyCredentialType;
interface PublicKeyCredential extends Credential {
readonly type: "public-key";
readonly rawId: ArrayBuffer;
readonly response: AuthenticatorAttestationResponse|AuthenticatorAssertionResponse;
readonly response: AuthenticatorResponse;
}
1 change: 0 additions & 1 deletion types/webgl2/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,6 @@ declare var WebGL2RenderingContext: {
readonly STENCIL_CLEAR_VALUE: number;
readonly STENCIL_FAIL: number;
readonly STENCIL_FUNC: number;
readonly STENCIL_INDEX: number;
readonly STENCIL_INDEX8: number;
readonly STENCIL_PASS_DEPTH_FAIL: number;
readonly STENCIL_PASS_DEPTH_PASS: number;
Expand Down