fs-extra: Fix tests

[ghost]

This was now a compile error thanks to microsoft/TypeScript#17660. copy takes an options object, not a function. (https://github.com/jprichardson/node-fs-extra/blob/master/docs/copy.md)

[DanielRosenwasser]

Looks like docs imply the callback is a valid 3rd argument.

[ghost]

Hm, but the callback takes an error, while in the tests it is shown taking a string. So it may have been intended to be a filter instead.
Waiting for response from authors: @alan-agius4 @midknight41 @shiftkey @mees-

[alan-agius4]

Hi @Andy-MS, I agree here that it seems that the tests were wrong in the first place.

Maybe we can indicate that in the callback the error can be undefined such as callback: (err: Error | undefined) => void

I also noticed something by checking the docs, that the filter signature itself is wrong as it seems that it accepts src and dest as params.

https://github.com/jprichardson/node-fs-extra/blob/master/docs/copy.md

const fs = require('fs-extra')

const filterFunc = (src, dest) => {
  // your logic here
  // it will be copied if return true
}

fs.copy('/tmp/mydir', '/tmp/mynewdir', { filter: filterFunc }, err => {
  if (err) return console.error(err)

  console.log('success!')
})

But for all these we can create a separate PR.

No objection in merging this from my end! 👍

[ghost]

@alan-agius4 Thanks, please create a PR for those changes too.

[alan-agius4]

@Andy-MS I'll try to find some time in the coming days :), thanks for your PR