Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log hashcode config not found #11584

Open
wants to merge 2 commits into
base: bugfix
Choose a base branch
from

Conversation

valentijnscholten
Copy link
Member

Recently when debugging a hash_code field config related issue I added this log line which could be helpful.

@github-actions github-actions bot added the docs label Jan 16, 2025
Copy link

dryrunsecurity bot commented Jan 16, 2025

DryRun Security Summary

The code change improves DefectDojo's deduplication functionality by introducing configurable settings for hash code computation, allowing organizations to customize the process while maintaining a fallback legacy algorithm for identifying and managing security findings.

Expand for full summary

Summary:

This code change is focused on improving the deduplication functionality within the DefectDojo
application. The key changes include the introduction of configurable settings for the hash code
computation, allowing the application to be tailored to the specific needs of the organization.
The code checks if the necessary configuration settings are defined, and if so, it uses those
values to determine the appropriate fields to use for computing the hash code and whether the
CWE field can be null. If the settings are not found, the code falls back to a legacy algorithm
for computing the hash code. The changes also include the use of a deduplicationLogger to log
debug and warning messages related to the hash code computation process.

From an application security perspective, these changes are a reasonable improvement to the
deduplication functionality of the DefectDojo application. Deduplication is an important feature
for managing and tracking security findings, as it helps to avoid duplicate entries and provides
a more accurate view of the security landscape. The use of configurable settings is a good
approach, as it allows the application to be tailored to the specific needs of the organization,
particularly if different types of security scans have different characteristics that require
different approaches to deduplication.

Files Changed:

  • dojo/models.py: This file has been updated to improve the deduplication functionality
    within the DefectDojo application. The changes include the introduction of configurable
    settings for the hash code computation, allowing the application to be tailored to the
    specific needs of the organization. The code checks if the necessary configuration settings
    are defined, and if so, it uses those values to determine the appropriate fields to use for
    computing the hash code and whether the CWE field can be null. If the settings are not found,
    the code falls back to a legacy algorithm for computing the hash code. The changes also include
    the use of a deduplicationLogger to log debug and warning messages related to the hash code
    computation process.

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Configured Codepaths Analyzer 2 findings

Overall Riskiness

🔴 Risk threshold exceeded.

We've notified @mtesauro, @grendel513.

View PR in the DryRun Dashboard.

@valentijnscholten valentijnscholten force-pushed the log-hashcode-config-not-found branch from bb39b44 to efed119 Compare January 16, 2025 19:48
@valentijnscholten valentijnscholten force-pushed the log-hashcode-config-not-found branch from efed119 to 941fa1f Compare January 16, 2025 19:54
@github-actions github-actions bot removed the docs label Jan 16, 2025
dojo/models.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants