[Serving] Initialize the storage size of multi-tier Embedding when se… #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candyzone
reviewed
Sep 2, 2022
|
|
||
| Status SavedModelOptimizer::RewriteEmbeddingVariableAttr( | ||
| embedding::StorageType st, std::string path) { | ||
| embedding::StorageType st, std::string path, std::vector<int64>& storage_size) { |
lixy9474
force-pushed
the
init_storage_size
branch
4 times, most recently
from
6179da6 to
523b55c
Compare
liutongxuan
approved these changes
Sep 5, 2022
liutongxuan
approved these changes
Sep 6, 2022
lixy9474
force-pushed
the
init_storage_size
branch
from
523b55c to
765306a
Compare
lixy9474
force-pushed
the
init_storage_size
branch
from
765306a to
155da91
Compare
liutongxuan
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rving.