Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new interfaces and tests for rotary_emb #1360

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Wrench-Git
Copy link
Collaborator

@Wrench-Git Wrench-Git commented Nov 18, 2024

Motivation and Context

This change is used to add an interface same with rotary_emb.apply_rotary, so we can mock the rotary_emb's interface when using InternEvo.

Description

It just add an new interface which still call the original cuda realization.

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Wrench-Git Wrench-Git changed the title add new interfaces and tests add new interfaces and tests for rotary_emb Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants