[Ascend] use aclnnUnique2 impl unique #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2024 14:26
added 2 commits
July 19, 2024 14:37
zhangzefeng92
approved these changes
Jul 22, 2024
jingguo-st
approved these changes
Jul 22, 2024
yangbofun
reviewed
Jul 22, 2024
| diopiError_t diopiUnique(diopiContextHandle_t ctx, diopiTensorHandle_t* out, diopiConstTensorHandle_t input, const int64_t* dim, bool sorted, bool returnCounts, | ||
| diopiTensorHandle_t indices, diopiTensorHandle_t* counts) { | ||
| // aclnnUnique2 only support dim == nullptr | ||
| ASCEND_CHECK_ABORT(dim == nullptr, "dim is not supported in aclnnUnique2"); |
There was a problem hiding this comment.
华为有aclnnUniqueDim来调用 带dim的unique.
There was a problem hiding this comment.
华为有aclnnUniqueDim来调用 带dim的unique.
嗯嗯，尝试用aclnnUniqueDim去实现支持dim的场景，不过有些测试用例没有通过，看模型中暂时使用的是unique2，先实现了不使用dim的算子，并且用ASCEND_CHECK_ABORT检查了dim。
There was a problem hiding this comment.
华为有aclnnUniqueDim来调用 带dim的unique.
嗯嗯，尝试用aclnnUniqueDim去实现支持dim的场景，不过有些测试用例没有通过，看模型中暂时使用的是unique2，先实现了不使用dim的算子，并且用ASCEND_CHECK_ABORT检查了dim。
在pr描述里写一下，并且在ASCEND_CHECK_ABORT这里写上可以调用aclnnUniqueDim.
yangbofun
reviewed
Jul 22, 2024
impl/ascend/functions/unique.cpp
Outdated
| // allocate temp inverse tensor | ||
| diopiTensorHandle_t inverseTmp = nullptr; | ||
| if (returnInverse || returnCounts) { | ||
| diopiRequireTensor(ctx, &inverseTmp, &inSize, nullptr, diopi_dtype_int64, diopi_device); |
There was a problem hiding this comment.
参考camb的requiresTensor写一些函数通用函数(华为上叫makeTensor)，这样就不用每次都从diopiSize_t来获取tensor
yewentao256
approved these changes
Jul 23, 2024
yangbofun
approved these changes
Jul 30, 2024
hellozmz
added a commit
to DeepLink-org/DIOPI.dev
that referenced
this pull request
Aug 2, 2024
--------- Co-authored-by: hellozmz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
[Ascend] use aclnnUnique2 impl unique
Description
Use cases (Optional)
BC-breaking (Optional)
Checklist
Before PR:
After PR: