Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ascend] fuj / fix rotary_embedding and getDefaultGenerator #1138

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Ascend] fuj / fix rotary_embedding and getDefaultGenerator #1138

wants to merge 3 commits into from

Conversation

jingguo-st
Copy link
Contributor

Motivation and Context

  1. fix rotary_embedding: using impl::aten::viewStorage instead of .view
  2. add getDefaultGenerator

Description

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jingguo-st jingguo-st requested a review from yangbofun as a code owner April 10, 2024 02:26
yangbofun
yangbofun reviewed Apr 12, 2024
View reviewed changes
impl/ascend_npu/torch_npu/csrc/DIOPIAdapter.cpp
namespace detail {

const at::Generator& getDefaultNPUGenerator(c10::DeviceIndex device_index) { INTERFACE_NOT_IMPL; }
const at::Generator& getDefaultNPUGenerator(c10::DeviceIndex device_index) {
if (device_index == -1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的-1用那个未初始化的变量来表示。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个后面再考虑，未初始化的变量在dipu里面

@jingguo-st jingguo-st closed this May 16, 2024
@jingguo-st jingguo-st reopened this May 16, 2024
@jingguo-st jingguo-st marked this pull request as draft May 16, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangbofun yangbofun yangbofun left review comments

@zhaoguochun1995 zhaoguochun1995 zhaoguochun1995 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingguo-st @yangbofun @zhaoguochun1995