Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ui: rework Mullvad peer list to be hierarchical #142

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

DeedleFake
Copy link
Owner

Closes #141.

@DeedleFake DeedleFake self-assigned this Jul 12, 2024
@DeedleFake
Copy link
Owner Author

DeedleFake commented Jul 12, 2024

I don't like how inefficient the Mullvad peer list update is. It has to create a map of slices, then turn that into a sorted slice of sorted slices. It's quite a few allocations and a decent number of sorts, too, though the sorts are pretty much all of lists that are probably less than 10 elements each, with one exception, so they're all quite fast.

Edit: To clarify why this is awkward, it's because it's doing that every single time Tailscale is polled, which is pretty much every five seconds or so. That's kind of awkward.

@DeedleFake DeedleFake merged commit deb1214 into master Jul 12, 2024
0 of 3 checks passed
@DeedleFake DeedleFake deleted the mullvad-accordians branch July 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mullvad duplicate exit-node entries
1 participant