Adding tests, refactoring code, adding documentation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the socket and argparse modules from the dependency, both of these modules are in the Python Standard Library.
… to requirements.
Requirements were too strict before so I made them more flexible by only requiring the minimum version needed. Added script to install the Golang dependencies and to build the shared object file. I've also added the Golang dependencies in the install script as well, it should be much easier to use the Golang library now.
|
@KingAkeem Please resolve conflicts and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added test for the Go code and I refactored it some to make it a little easier to understand. I also added documentation on testing and refactored code. I think we should switch to using the Go module for the get links method because it's much faster.