Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature_Save_To_File #31

Merged
merged 2 commits into from
Jul 25, 2017
Merged

Feature_Save_To_File #31

merged 2 commits into from
Jul 25, 2017

Conversation

y-mehta
Copy link
Contributor

@y-mehta y-mehta commented Jul 25, 2017 •
edited by PSNAppz
Loading

Added :

y-mehta added 2 commits July 25, 2017 14:09
@y-mehta
Save-To-File-Feature
acf970d 
Save to file(json) feature by Yash.
@y-mehta
Save-To-File-Feature-Commit2
8631ae7 
Save to file(json) feature.
@PSNAppz
Copy link
Member

PSNAppz commented Jul 25, 2017

@y-mehta That was fast. Great work. 👍

Our @DedSecInside/reviewers team will review this and will merge it as soon as it is ready to merge.

@PSNAppz PSNAppz requested review from agrepravin and PSNAppz July 25, 2017 14:39
PSNAppz
PSNAppz reviewed Jul 25, 2017
View reviewed changes
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Awaiting review status from @DedSecInside/reviewers .

@agrepravin
Copy link
Contributor

@y-mehta can u write test cases for ur module? If possible?

@y-mehta
Copy link
Contributor Author

y-mehta commented Jul 25, 2017

@agrepravin I'm sorry, but I haven't written any test cases for python till now. Still I will try to write but probably it will consume more time.

@PSNAppz
Copy link
Member

PSNAppz commented Jul 25, 2017

@y-mehta Thats ok we'll write the test cases. Thank you for the PR.

@PSNAppz PSNAppz removed the request for review from agrepravin July 25, 2017 15:32
@PSNAppz PSNAppz merged commit 9118ca0 into DedSecInside:dev Jul 25, 2017
@y-mehta
Copy link
Contributor Author

y-mehta commented Jul 25, 2017

Thanks @PSNAppz

@agrepravin
Copy link
Contributor

agrepravin commented Jul 25, 2017 •
edited by PSNAppz
Loading

No prb @y-mehta we will write but good to know how to write unit tests

@PSNAppz
Copy link
Member

PSNAppz commented Jul 25, 2017

@y-mehta You are added to our contributor list. 👍

@y-mehta y-mehta mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSNAppz PSNAppz PSNAppz left review comments

Assignees
No one assigned
Labels
Med Priority Merge Approved New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-mehta @PSNAppz @agrepravin