Poetry Implementation #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional changes: - Changed Python version to 3.9
Additional changes: - Changed Dockerfile Python image from 3.6-stretch to 3
This change avoids certain relative import errors like:
- "No module named modules"
|
There are some fields in both of the pyproject.toml files that I don't know whether they are right or not. These are: |
PSNAppz
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
@neolight1010 Looks good to me. :)
License is GNU General Public License v3.0, which is correct in the .toml file.
v1.3 is our latest release version.
Authors for now you can leave it as dedsecinside. Later we'll add the names of all our contributors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #198
Changes Proposed
Also, a small change to
install.shshould fix relative import errors when using that method of installation.Other minor changes:
Explanation of Changes
Currently, TorBot uses a simple pip freeze and requirements.txt method for managing its dependencies. This has led to some issues, like #177. With the use of a proper dependency management tool, this can be avoided.
Also, issue #198 is resolved by a adding a
--pathsflag to thepyinstallercommand ininstall.sh. This also fixes the same error when trying to run the Docker image of the app.Screenshots of new feature/change