Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor analyzer #170

Merged
merged 8 commits into from
Oct 7, 2019
Merged

Refactor analyzer #170

merged 8 commits into from
Oct 7, 2019

Conversation

KingAkeem
Copy link
Member

Fixes #163

Changes Proposed

  • Create new defaultStyle variable to remove duplicate TreeStyle creation, simpify save and show methods & move default values to a single location
  • Remove unnecessary initialize_tree method
  • Simplify build_tree function

Explanation of Changes

Removes unnecessary code and simplify functions/methods

modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Show resolved Hide resolved
modules/analyzer.py Show resolved Hide resolved
modules/analyzer.py Outdated Show resolved Hide resolved
modules/analyzer.py Show resolved Hide resolved
@PSNAppz
Copy link
Member

PSNAppz commented Oct 6, 2019

@KingAkeem See the Travis-CI error.

modules/tests/test_pagereader.py Show resolved Hide resolved
modules/tests/test_getweblinks.py Show resolved Hide resolved
modules/tests/test_getweblinks.py Show resolved Hide resolved
modules/tests/test_analyzer.py Show resolved Hide resolved
Copy link
Member

@PSNAppz PSNAppz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work @KingAkeem

@PSNAppz PSNAppz merged commit c50db85 into dev Oct 7, 2019
@KingAkeem KingAkeem deleted the refactor_analyzer branch July 9, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor analyzer.py
2 participants