Add function to traverse links using Breadth First Search #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KingAkeem Awesome work 👏🏻. |
agrepravin
reviewed
Aug 9, 2018
|
|
||
| toVisit = list() | ||
| for link in links: | ||
| if targetLink == link and targetLink: |
There was a problem hiding this comment.
Don't see value of and condition here. If targetLink == link it will always be targetLink, right?
There was a problem hiding this comment.
I want to make sure targetLink since Python is a dynamic language, it's impossible to tell ahead of time what items a list may contain. If a None were to somehow get inserted, I don't want it to return a false positive.
modules/getweblinks.py
Outdated
| for link in links: | ||
| if targetLink == link and targetLink: | ||
| return depth | ||
| resp = requests.get(link) |
There was a problem hiding this comment.
Good catch, didn't think about that. I'm going to just put a try-except block and just pass errors. If there are errors, then we can just assume the link isn't valid.
agrepravin
approved these changes
Aug 9, 2018
PSNAppz
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #102
Changes Proposed
Explanation of Changes
Two functions have been added, one which accepts the html of a webpage and an integer which represents the depth at which to stop. This function invokes the traversal function which searches the links using Breadth First Search algorithm.