Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@vtmn/svelte): dispatch missing events on VtmnInput + export ref on VtmnIcon #1469

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat(@vtmn/svelte): dispatch missing events on VtmnInput + export ref on VtmnIcon #1469

merged 1 commit into from
Oct 19, 2023

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Oct 19, 2023 •
edited
Loading

Changes description

Dispatch missing events on VtmnInput component

  • on:keyup
  • on:keydown
  • on:keypress

Add ref on VtmnIcon

Context

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners October 19, 2023 16:13
@lauthieb lauthieb merged commit 61417fb into main Oct 19, 2023
@lauthieb lauthieb deleted the fix/common-changes branch October 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauthieb lauthieb lauthieb approved these changes

@thibault-mahe thibault-mahe Awaiting requested review from thibault-mahe thibault-mahe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlahey @lauthieb