Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): fix lint issues #1465

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix(build): fix lint issues #1465

merged 1 commit into from
Sep 29, 2023

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Sep 29, 2023 •
edited
Loading

Changes description

Fix issue with the build
https://github.com/Decathlon/vitamin-web/actions/runs/6349658717/job/17248170407

Context

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners September 29, 2023 12:19
@Tlahey Tlahey merged commit 80cf58f into main Sep 29, 2023
@Tlahey Tlahey deleted the fix/lint-build branch September 29, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-mahe thibault-mahe thibault-mahe approved these changes

@lauthieb lauthieb lauthieb approved these changes

@Shyrro Shyrro Shyrro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tlahey @thibault-mahe @lauthieb @Shyrro