fix(build): remove unnecessary parameter requirements for GitHub release #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant `NugetFeed` and `NugetApiKey` parameter requirements from the `PushToRelease` target in `ITargets.cs`. This simplifies configuration for GitHub release workflows.
There was a problem hiding this comment.
Pull request overview
This PR fixes a configuration issue in the build targets by removing unnecessary NuGet-related parameter requirements from the PushToRelease target. The target is responsible for uploading artifacts to GitHub releases and only needs GitHub authentication, not NuGet credentials.
- Removes incorrect
.RequiresParam(nameof(NugetFeed), nameof(NugetApiKey))from thePushToReleasetarget - Simplifies GitHub release workflow configuration by eliminating unnecessary parameter dependencies
- Maintains proper separation of concerns between NuGet and GitHub release workflows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant
NugetFeedandNugetApiKeyparameter requirements from thePushToReleasetarget inITargets.cs. This simplifies configuration for GitHub release workflows.