Merged
Conversation
DecSmith42
force-pushed
the
fix/secret-masking
branch
from
5d0b5a1 to
e88c59a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Improves secret masking consistency across production and test code by introducing a new SanitizeSecrets string extension and applying it in parameter masking and logging.
Changes:
- Added
SanitizeSecretsto centralize and harden secret masking behavior. - Updated
ParamServiceand logging to sanitize secrets before output. - Refactored/expanded console output masking tests and updated API surface verification.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| DecSm.Atom/Util/StringUtil.cs | Adds the new SanitizeSecrets implementation for masking secrets across whitespace/newlines. |
| DecSm.Atom/Params/ParamService.cs | Switches MaskMatchingSecrets to use SanitizeSecrets. |
| DecSm.Atom/Logging/SpectreLogger.cs | Sanitizes log messages via IParamService before escaping markup/output. |
| DecSm.Atom.Tests/ClassTests/Logging/MaskingAnsiConsoleOutputTests.cs | Updates tests to use new masking logic and adds a “multiline” case. |
| DecSm.Atom.Tests/ApiSurfaceTests/PublicApiSurfaceTests.VerifyPublicApiSurface.verified.txt | Updates verified public API list to include SanitizeSecrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DecSm.Atom.Tests/ClassTests/Logging/MaskingAnsiConsoleOutputTests.cs
Outdated
Show resolved
Hide resolved
Added the `SanitizeSecrets` method to `StringUtil` for improved secret masking logic, allowing for better handling of multi-line secrets and whitespace. Replaced existing `MaskMatchingSecrets` calls to use the new method. Updated related logic in `ParamService` and logging output for consistency.
Ensured log messages are masked for secrets using `MaskMatchingSecrets` before processing. Added a safeguard to protect sensitive data in logging output.
DecSmith42
force-pushed
the
fix/secret-masking
branch
from
e88c59a to
b60f3ca
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated XML comments in `StringUtil` to improve clarity and accuracy. Enhanced descriptions for parameters, return values, and overall method behavior, ensuring consistency and better developer understanding.
Updated XML comments in `ParamService` to improve clarity by including an example of the mask used for secret replacement.
Removed redundant `EscapeMarkup` usage in `SpectreLogger`. This ensures the markup is properly rendered without escaping, improving the readability of log output.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of secret masking in log output and refactors the underlying implementation to improve reliability and maintainability. The most important changes are the introduction of a new
SanitizeSecretsutility method, updates to logging components to ensure secrets are masked everywhere, and improvements to theIParamServiceinterface and its implementation.Secret masking improvements:
SanitizeSecretsmethod toStringUtil, which replaces secret substrings with a mask and handles edge cases like short secrets and empty input. ([DecSm.Atom/Util/StringUtil.csR94-R123](https://github.com/DecSmith42/atom/pull/281/files#diff-0ea3174af5e67049cad68f62502515d8f75441e84643ec506257820cd5422fc1R94-R123))ParamService.MaskMatchingSecretsto use the newSanitizeSecretsmethod, simplifying the masking logic and ensuring consistency. ([DecSm.Atom/Params/ParamService.csL160-R160](https://github.com/DecSmith42/atom/pull/281/files#diff-0c40242605d992515cab81b9bb1230373f81aea228d162ae3ded16e0827f37ddL160-R160))Logging updates:
SpectreLogger.Logto mask secrets in log messages before formatting and output, ensuring sensitive data is not exposed in logs. ([DecSm.Atom/Logging/SpectreLogger.csR123-R125](https://github.com/DecSmith42/atom/pull/281/files#diff-ed76b61733cc309bc6065fda74fb29bc705814662b5125f5fc2f2d31d39f4608R123-R125))MaskingAnsiConsoleOutput.Writeto use the refactored masking logic, improving performance and reliability. ([DecSm.Atom/Logging/MaskingAnsiConsoleOutput.csL66-R66](https://github.com/DecSmith42/atom/pull/281/files#diff-e1a7820b8351c1672a1c680731c358d2245d2135f24ae82cd3688938740fea15L66-R66))SpectreLoggerto avoid double escaping and ensure masked output is displayed correctly. ([DecSm.Atom/Logging/SpectreLogger.csL134-R136](https://github.com/DecSmith42/atom/pull/281/files#diff-ed76b61733cc309bc6065fda74fb29bc705814662b5125f5fc2f2d31d39f4608L134-R136))API and documentation enhancements:
IParamServiceinterface documentation to clarify the masking behavior and provide more accurate descriptions. ([DecSm.Atom/Params/ParamService.csL80-R80](https://github.com/DecSmith42/atom/pull/281/files#diff-0c40242605d992515cab81b9bb1230373f81aea228d162ae3ded16e0827f37ddL80-R80))SanitizeSecretsto the public API surface verification, making it available for testing and usage. ([DecSm.Atom.Tests/ApiSurfaceTests/PublicApiSurfaceTests.VerifyPublicApiSurface.verified.txtR1916-R1918](https://github.com/DecSmith42/atom/pull/281/files#diff-6d9417313cb728d443e8455adbbf1e331f52778bb2e5d7dc1eddefabe2c5010eR1916-R1918))