Skip to content

fix(help): Display default/configured values when null as well, not just when empty #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DecSmith42 merged 2 commits into from
Sep 3, 2025
Merged

fix(help): Display default/configured values when null as well, not just when empty #216

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2f7afb
fix(help): Display default/configured values when null as well, not j…
DecSmith42 Sep 3, 2025
2cbcedc
fix(params-tests): Updated expected test result
DecSmith42 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions DecSm.Atom/Help/HelpService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,11 @@ private void WriteCommand(TargetModel target)

foreach (var optionalParam in optionalParams)
{
var defaultValue = optionalParam.Param.DefaultValue;
var defaultValue = optionalParam.Param.DefaultValue ?? string.Empty;

var configuredValue = config
.GetSection("Params")[optionalParam.Param.ArgName];
.GetSection("Params")[optionalParam.Param.ArgName] ??
string.Empty;

var defaultDisplay = (defaultValue, configuredValue) switch
{
Expand Down
Loading