Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for build to complete before launching browser #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pieterjongsma
Copy link

When web-ext is launched before the build has completed, there is a crash (below) because it cannot find the manifest file. Currently, the build is started but not awaited. Because of this, web-ext is only run successfully when by coincidence the build is finished faster than web-ext tries to access the manifest. In my experience, this only happens when I haven't launched Firefox since rebooting.

This pull request makes sure the initial build is awaited before launching the browser.

Error when web-ext runs before the build is finished:

npm verb cli /home/USER/.asdf/installs/nodejs/21.7.1/bin/node /home/pieterjongsma/.asdf/installs/nodejs/21.7.1/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verb title npm run start firefox
npm verb argv "run" "start" "firefox" "--loglevel" "verbose"
npm verb logfile logs-max:10 dir:/home/pieterjongsma/.npm/_logs/2024-05-09T07_31_33_128Z-
npm verb logfile /home/pieterjongsma/.npm/_logs/2024-05-09T07_31_33_128Z-debug-0.log

> [email protected] start
> node --loader ts-node/esm scripts/build.ts --dev firefox

(node:22306) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
Building "background" from src/pages/background/index.js:: 106.095ms
Copying public files for v2: 18.947ms
Building "devtools" from src/pages/devtools/index.html: 24.01ms
Building "content" from src/pages/content/index.tsx:: 136.245ms
[0] Applying config file: ./package.json
[0] Running web extension from /home/pieterjongsma/Projects/2023-2024/browser-extension/dist/v2
[0] 
[0] InvalidManifest: Could not read manifest.json file at /home/pieterjongsma/Projects/2023-2024/browser-extension/dist/v2/manifest.json: Error: ENOENT: no such file or directory, open '/home/pieterjongsma/Projects/2023-2024/browser-extension/dist/v2/manifest.json'
[0] 
[0] web-ext run --start-url=example.com --profile-create-if-missing --browser-console --keep-profile-changes --source-dir="/home/pieterjongsma/Projects/2023-2024/browser-extension/dist/v2" --firefox-binary="firefox" --firefox-profile="/home/pieterjongsma/Projects/2023-2024/browser-extension/tmp/profiles/firefox" exited with code 1
web-ext run --start-url=example.com --profile-create-if-missing --browser-console --keep-profile-changes --source-dir="/home/pieterjongsma/Projects/2023-2024/browser-extension/dist/v2" --firefox-binary="firefox" --firefox-profile="/home/pieterjongsma/Projects/2023-2024/browser-extension/tmp/profiles/firefox":
 exited with code 1

file:///home/pieterjongsma/Projects/2023-2024/browser-extension/scripts/build.ts:472
                throw new Error(command.error);
                      ^

Error: [object Object]
    at file:///home/pieterjongsma/Projects/2023-2024/browser-extension/scripts/build.ts:472:23

Node.js v21.7.1
npm verb exit 1
npm verb code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant