Merge pull request #17 from DeanWay/13-optional-id

allow id on request structure
DeanWay · Nov 29, 2019 · 46b859a · 46b859a
2 parents c0c013a + e3722b3
commit 46b859a
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/pydantic_jsonapi/request.py b/pydantic_jsonapi/request.py
@@ -14,6 +14,7 @@ class RequestDataModel(GenericModel, Generic[TypeT, AttributesT]):
     """
     type: TypeT
     attributes: AttributesT
+    id: Optional[str]
     relationships: Optional[RequestRelationshipsType]
 
 

diff --git a/tests/test_request.py b/tests/test_request.py
@@ -18,6 +18,7 @@ def test_attributes_as_dict(self):
                 'type': 'item',
                 'attributes': {},
                 'relationships': None,
+                'id': None,
             }
         }
 
@@ -32,6 +33,7 @@ def test_attributes_as_item_model(self):
                     'price': 1.20
                 },
                 'relationships': None,
+                'id': None,
             }
         }
         my_request_obj = ItemRequest(**obj_to_validate)
@@ -113,4 +115,39 @@ def test_request_with_relationships(self):
             },
         }
         my_request_obj = MyRequest(**obj_to_validate)
-        assert my_request_obj.dict() == obj_to_validate
+        assert my_request_obj.dict() == {
+            'data': {
+                'type': 'item',
+                'attributes': {},
+                'relationships': {
+                    'sold_at': {
+                        'data': {
+                            'type': 'store',
+                            'id': 'abc123',
+                            'meta': None
+                        },
+                    }
+                },
+                'id': None
+            },
+        }
+
+    def test_request_with_id(self):
+        MyRequest = JsonApiRequest('item', dict)
+        obj_to_validate = {
+            'data': {
+                'type': 'item',
+                'attributes': {},
+                'id': 'abc123'
+            },
+        }
+        my_request_obj = MyRequest(**obj_to_validate)
+        assert my_request_obj.dict() == {
+            'data': {
+                'type': 'item',
+                'attributes': {},
+                'relationships': None,
+                'id': 'abc123',
+            },
+        }
+