(Idea) feature: update configuration for turn-based #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikki407
reviewed
Jan 24, 2022
handyrl/train.py
Outdated
| @@ -165,7 +165,10 @@ def forward_prediction(model, hidden, batch, args): | |||
| o = o.view(*batch['turn_mask'].size()[:2], -1, o.size(-1)) | |||
| if k == 'policy': | |||
| # gather turn player's policies | |||
There was a problem hiding this comment.
This comment and line 170 comment is duplicated.
|
Thank you, it becomes that the two functions can be totally understood and easy to be used by users. |
|
Could you update parameters.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn-based batch creation and zero-sum averaging are different and independent.
Moreover, these should be set False at default for safety.