Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to policy/v1 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: migrate to policy/v1 #1

wants to merge 1 commit into from

Conversation

yz89122
Copy link
Member

@yz89122 yz89122 commented Oct 2, 2023 •
edited
Loading

@yz89122 yz89122 marked this pull request as draft October 2, 2023 09:11
@yz89122 yz89122 marked this pull request as ready for review October 2, 2023 09:21
tommy351
tommy351 reviewed Oct 4, 2023
View reviewed changes
helm/scylla-manager/templates/controller_pdb.yaml Outdated
@@ -7,4 +7,4 @@ spec:
minAvailable: 1
selector:
matchLabels:
{{- include "scylla-manager.controllerSelectorLabels" . | nindent 6 }}
{ { - include "scylla-manager.controllerSelectorLabels" . | nindent 6 } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ { - include "scylla-manager.controllerSelectorLabels" . | nindent 6 } }
{{ - include "scylla-manager.controllerSelectorLabels" . | nindent 6 }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should disable my formatter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@yz89122 yz89122 force-pushed the chore/migrate-to-policy-v1 branch from 344b40c to b09453b Compare October 5, 2023 09:32
@yz89122 yz89122 force-pushed the chore/migrate-to-policy-v1 branch from b09453b to cf635e2 Compare October 5, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taco-lin taco-lin taco-lin approved these changes

@yckao yckao yckao approved these changes

@tommy351 tommy351 tommy351 approved these changes

@benjamin99 benjamin99 benjamin99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yz89122 @benjamin99 @tommy351 @yckao @taco-lin