Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GitHub workflow "tag, release and publish" to be executed automatically, which kind of "disables" it #291

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

MrChocolatine
Copy link
Member

@MrChocolatine MrChocolatine commented Oct 1, 2023

This PR properly "disables" our GitHub workflow "tag, release and publish".

It is true the workflow was already disabled in #278 , but not correctly.
The workflow is still existing, but with no content, which is an invalid syntax for GitHub workflows.
Because of that, we are constantly getting the same error over and over:

We have 2 alternatives here:

  1. To disable the workflow via GitHub web interface

    a. On this page https://github.com/DazzlingFugu/ember-slugify/actions/workflows/tag-release-publish.yml
    b. Click the ... button in the top right corner > Disable workflow

  2. To make sure the workflow can only be triggered manually (which is defined by the syntax on: workflow_dispatch in the YAML file)

    This kind of "disables" the workflow as it won't be executed automatically anymore.
    There is no syntax to "really disable" a workflow. (like is_disabled: true for instance)

    See:

I went for option (2) so we can actually track this change, to see what happened to the workflow.
With option (1), one could not easily know why the workflow does not run.

@MrChocolatine MrChocolatine requested a review from a team as a code owner October 1, 2023 12:12
This partially reverts commit commit/967fc13f8976ade382ee1b07abd0e8baf8637cc3 .
@MrChocolatine MrChocolatine force-pushed the ci-fix-error-no-event-triggers-defined branch from d3da5c4 to 1d2150e Compare October 1, 2023 12:14
@MrChocolatine MrChocolatine changed the title Revert "Release version 5.0.0 (#278)" Properly "disable" our GitHub workflow "tag, release and publish" Oct 1, 2023
@MrChocolatine MrChocolatine merged commit 8615f90 into master Oct 2, 2023
8 checks passed
@MrChocolatine MrChocolatine deleted the ci-fix-error-no-event-triggers-defined branch October 2, 2023 14:34
@MrChocolatine MrChocolatine changed the title Properly "disable" our GitHub workflow "tag, release and publish" Prevent GitHub workflow "tag, release and publish" to be executed automatically, which somehow "disables" it Nov 13, 2023
@MrChocolatine MrChocolatine changed the title Prevent GitHub workflow "tag, release and publish" to be executed automatically, which somehow "disables" it Prevent GitHub workflow "tag, release and publish" to be executed automatically, which kind of "disables" it Nov 13, 2023
@MrChocolatine MrChocolatine mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants