Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/ Ember 4.4 #189

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Build/ Ember 4.4 #189

merged 2 commits into from
Aug 11, 2022

Conversation

BlueCutOfficial
Copy link
Member

@BlueCutOfficial BlueCutOfficial commented Aug 11, 2022 •
edited
Loading

Breaking build

Ember 4.4 (#189)

  • The addon has been updated to Ember 4.4 using ember-cli-update.
  • This update drops the support for jquery integration.

@BlueCutOfficial BlueCutOfficial requested a review from a team as a code owner August 11, 2022 10:07
yonmey
yonmey approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@yonmey yonmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good, I guess most of the changes are auto-generated/modified.

@BlueCutOfficial BlueCutOfficial merged commit a6af8ea into master Aug 11, 2022
@BlueCutOfficial BlueCutOfficial deleted the build/ember-4 branch August 11, 2022 14:40
@MrChocolatine MrChocolatine added the dependencies Pull requests that update a dependency file label Aug 12, 2022
@BlueCutOfficial BlueCutOfficial mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonmey yonmey yonmey approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlueCutOfficial @yonmey @MrChocolatine