Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eslint v8 compatibility #182

Merged
merged 4 commits into from
Aug 10, 2022
Merged

chore: eslint v8 compatibility #182

merged 4 commits into from
Aug 10, 2022

Conversation

ndekeister-us
Copy link
Member

@ndekeister-us ndekeister-us commented Jun 3, 2022 •
edited
Loading

Chore

Add compatibility for ESLint v8 (#182)

Use correct configuration in .template-lintrc.js file (#182)

Extends recommended instead of octane which don't exists anymore

@ndekeister-us ndekeister-us marked this pull request as ready for review June 3, 2022 11:26
@ndekeister-us ndekeister-us requested a review from a team as a code owner June 3, 2022 11:26
@ndekeister-us ndekeister-us mentioned this pull request Jun 3, 2022
Closed
yonmey
yonmey reviewed Jun 3, 2022
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@BlueCutOfficial @yonmey
config: update .eslintrc.js
e1cdc7d 
Co-authored-by: Yon Mellado <[email protected]>
@BlueCutOfficial
Copy link
Member

I rebased master and committed @yonmey suggestion. Is it good to you @ndekeister-us?

romgere
romgere approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@romgere romgere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@ndekeister-us ndekeister-us merged commit eef7d40 into master Aug 10, 2022
@ndekeister-us ndekeister-us deleted the chore/eslint8_compatibility branch August 10, 2022 08:20
@BlueCutOfficial BlueCutOfficial mentioned this pull request Aug 10, 2022
Merged
@MrChocolatine MrChocolatine added the dependencies Pull requests that update a dependency file label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonmey yonmey yonmey approved these changes

@romgere romgere romgere approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ndekeister-us @BlueCutOfficial @yonmey @romgere @MrChocolatine