breaking: use slugify and emoji.json #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatWizard
force-pushed
the
breaking/use-slugify-and-emojijson
branch
4 times, most recently
from
5eb0199
to
b8f910f
Compare
lifeart
approved these changes
Jan 19, 2022
GreatWizard
force-pushed
the
breaking/use-slugify-and-emojijson
branch
3 times, most recently
from
3e2183b
to
6a68506
Compare
GreatWizard
force-pushed
the
breaking/use-slugify-and-emojijson
branch
from
6a68506
to
8729c57
Compare
romgere
approved these changes
Jan 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
Use slugify and emoji.json (#169)
speakingurlbyslugify, it's maintained, lighter and faster for the same resultemoji.jsonin order to "translate" unicode emojiunormto use nativenormalizestring's function