Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/ Remove ember-maybe-import-regenerator #161

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 19, 2021

Build

Remove ember-maybe-import-regenerator (#161)

This dependency is related to IE11 targets, which is no longer supported.

@dependabot dependabot bot requested a review from a team as a code owner November 19, 2021 23:03
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 19, 2021
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch 3 times, most recently from 9b5120a to 78401b7 Compare January 19, 2022 17:02
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch from 78401b7 to 9127dba Compare May 2, 2022 16:19
@dependabot dependabot bot requested a review from a team as a code owner May 2, 2022 16:19
@GreatWizard GreatWizard force-pushed the master branch 4 times, most recently from 4b009b5 to 6a52f48 Compare May 2, 2022 16:48
@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch 2 times, most recently from 9992673 to 23b423b Compare May 10, 2022 08:06
@romgere
Copy link
Contributor

romgere commented May 12, 2022

This exists to give applications that still service IE11 users and also wish to use async/await or generators.

I think we can remove it, we don't need IE support for dummy app ...

@dependabot dependabot bot force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch from 23b423b to 8a5c707 Compare August 9, 2022 15:29
@BlueCutOfficial BlueCutOfficial force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch from 8a5c707 to ba6bd5d Compare August 9, 2022 15:35
Copy link
Contributor

@romgere romgere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the PR title ?

@BlueCutOfficial BlueCutOfficial changed the title build(deps-dev): bump ember-maybe-import-regenerator from 0.1.6 to 1.0.0 Build/ Remove ember-maybe-import-regenerator Aug 10, 2022
dependabot bot and others added 2 commits August 10, 2022 11:36
Bumps [ember-maybe-import-regenerator](https://github.com/machty/ember-maybe-import-regenerator) from 0.1.6 to 1.0.0.
- [Release notes](https://github.com/machty/ember-maybe-import-regenerator/releases)
- [Commits](https://github.com/machty/ember-maybe-import-regenerator/commits/v1.0.0)

---
updated-dependencies:
- dependency-name: ember-maybe-import-regenerator
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@BlueCutOfficial BlueCutOfficial force-pushed the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch from ba6bd5d to f53a35f Compare August 10, 2022 09:37
@BlueCutOfficial BlueCutOfficial merged commit 39401fc into master Aug 10, 2022
@BlueCutOfficial BlueCutOfficial deleted the dependabot-npm_and_yarn-ember-maybe-import-regenerator-1.0.0 branch August 10, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants