Upgrade Ember.js from v3.28.3 to v4.10.0 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
added
dependencies
- Standardise helper's function signature and body To match what is generated by default when creating a new helper. - Fix types errors provided by implicit TypeScript checks This will help whenever the project is migrated to TS
What was done and why: - After the `stream` module, the modules `util` and `process` had to be added to the dependencies as well in order to satisfy Webpack v5 which does not include polyfills anymore, otherwise tests were failing. - https://webpack.js.org/migrate/5/ - https://webpack.js.org/configuration/resolve/#resolvefallback - https://github.com/ef4/ember-auto-import/blob/v2.6.0/docs/upgrade-guide-2.0.md - https://gist.github.com/ef4/d2cf5672a93cf241fd47c020b9b3066a For the `process` module, adding it to the `fallback` key was not working, it had to be included in the `plugins` key: - https://stackoverflow.com/questions/65018431/webpack-5-uncaught-referenceerror-process-is-not-defined/65018686#65018686 - https://discord.com/channels/480462759797063690/898671957007011841/898682272847384596 Overall, these messages on Discord give the entire final solution in this commit. - `wepack` moved to the dependencies because otherwise `eslint-plugin-n` was returning the error: ``` "webpack" is not published.eslintn/no-unpublished-require ``` See: - https://github.com/eslint-community/eslint-plugin-n/blob/15.6.1/docs/rules/no-unpublished-require.md - mysticatea/eslint-plugin-node#47
BlueCutOfficial
force-pushed
the
upgrade-ember-to-lts-version-4.10
branch
from
53338ed
to
99cbf73
Compare
|
@MrChocolatine you were almost there. I dropped the commits "remove ember-page-title" (the dummy app template uses it) and "rebuild yarn.lock" and then rebase the MR with |
|
The tradeoff of having EDIT: I no longer have the error locally, something was maybe out of date on my side. |
BlueCutOfficial
force-pushed
the
upgrade-ember-to-lts-version-4.10
branch
from
94509cb
to
99cbf73
Compare
BlueCutOfficial
approved these changes
Apr 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Breaking: Upgrade to Ember.js version 4.10 (#103)
Requirements bumped to Ember.js/CLI version 3.28 or above.
Close #100 , #101, #102 .