Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore: upgrades to Ember 5.4 #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Pixelik
Copy link
Collaborator

@Pixelik Pixelik commented Jan 10, 2024

Chore

Upgrades to Ember 5.4

  • makes the minimum amount of changes needed to make it Ember-5-compatible

Upgrades dependencies

Most notably:

  • ember-concurrency from v0.8 to v3
  • ember-concurrency-decorators from v0.5 to v2
  • ember-resolver from v5 to v11

Removes dependencies

Most notably:

  • ember-decorators (not needed in Ember 5)
  • @ember/jquery (not needed)
  • ember-cli-changelog (not compatible with Ember 5) ⚠️
  • ember-cli-release (not compatible with Ember 5) ⚠️
  • ember-cli-shims (not needed in Ember 5)
  • ember-paper (not compatible with Ember 5) ⚠️
  • ember-disable-prototype-extensions (removed by ember-cli-update)
  • ember-export-application-global (removed by ember-cli-update)

Adds resolutions

In order to enforce Ember-5-compatible versions of various modules

Documentation

⚠️ deactivates documentation as it was using ember-paper which is not Ember-5-compatible

Deactivates release process

Making a release is no longer possible because the following modules had to be removed as they are not ember-5-compatible:

  1. ember-cli-changelog
  2. ember-cli-release

⚠️ As a result, the purpose of this PR is to have an Ember-5-compatible branch that works as expected & can be installed asap in an SPA that is on Ember 5. Once releasing & documentation (further refactoring will be required) is reinstated, a proper release could then also be made.

@Pixelik Pixelik changed the title [WIP] chore: upgrades to Ember 5 [WIP] chore: upgrades to Ember 5.4 Jan 10, 2024
@Pixelik Pixelik marked this pull request as ready for review January 10, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant