Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of /testing/index.md page. #255

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

antoheri
Copy link

@antoheri antoheri commented Oct 3, 2024

Fixes #111

Copy link
Member

@BlueCutOfficial BlueCutOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @antoheri ❤️ I commented a couple of tiny typos and a few proposals to improve a little bit some sentences.

guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
@@ -1,78 +1,78 @@
Ember gives you **the power to write tests and be productive from day one**. You can be confident that your app will be correct today and years from now. A question remains: _How_ should you write tests?
Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans des années. Une question demeure : Comment devriez-vous écrire des tests ?
Copy link
Member

@MrChocolatine MrChocolatine Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better phrasing:

Suggested change
Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans des années. Une question demeure : Comment devriez-vous écrire des tests ?
Ember vous donne **la puissance d'écrire des tests et d'être productif dès le premier jour**. Vous pouvez être sûr que votre application fonctionnera correctement aujourd'hui et dans les années à venir. Une question demeure : Comment devriez-vous écrire des tests ?

guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
guides/testing/index.md Outdated Show resolved Hide resolved
antoheri and others added 15 commits October 7, 2024 09:50
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
Co-authored-by: MrChocolatine <[email protected]>
@antoheri
Copy link
Author

antoheri commented Oct 7, 2024

Thank's for the review and the suggestions !

Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change from the previous review was forgotten.

guides/testing/index.md Outdated Show resolved Hide resolved
@MrChocolatine MrChocolatine self-requested a review October 7, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate /testing/index.md, Ember 4.7
3 participants