Update guidemaker-elt, remove what was moved in the addon #208
Conversation
BlueCutOfficial
force-pushed
the
update-guidemaker-elt
branch
from
95cefd5
to
c81e352
Compare
| texts: { | ||
| searchInputPlaceholder: 'Rechercher dans le Guide', | ||
| searchResultsPlaceholder: 'Résultats de la recherche', | ||
| currentChapter: 'Nous avons couvert', |
There was a problem hiding this comment.
Are we sure about this translation?
Shouldn't it be Chapitre actuel instead? To match the following nextChapter: 'Chapitre suivant'.
There was a problem hiding this comment.
It's an accurate translation, but I admit the English is a bit verbose for my taste, especially as a
next button" text 🤔 but it makes sense because it's really on the "next button" => "Nous avons couvert ça, suivant : ça"
I think if we want to rework that part if should be in the Guidemaker addon directly, so I leave it this way for now.
There was a problem hiding this comment.
I think I need more clarification because I don't get the "the English is a bit verbose", assuming you are talking about "next chapter / chapitre suivant" ... ? What were you talking about?
When reading any guide, it's more than natural to see "next chapter / chapitre suivant" on a button that, well, actually brings us to the next page of the guide/current section we are reading.
But I don't see where this is used in the guides so I may be missing some context.
Build
Update
guidemaker-ember-locale-template(#208)The addon has been published on NPM so we can now use the tag
^1.0.0. A few changes have been made to adapt the app:table-of-contentscomponent because its code has been moved in the addon directlytable-of-contents)hbstemplates of the addon