CI - Reuse organisation's workflows to lint, test, tag and publish #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
14 times, most recently
from
bc190f7
to
d1fe4aa
Compare
MrChocolatine
commented
Oct 29, 2021
.github/workflows/ci.yml
Outdated
| EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }} | ||
| run: node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO | ||
| org: | ||
| uses: peopledoc/.github/.github/workflows/emberjs-addons-ci.yml@add-reusable-workflow-emberjs-addon |
There was a problem hiding this comment.
A version (here @add-reusable-workflow-emberjs-addon) is required otherwise we get the error:
https://github.com/peopledoc/ember-feature-controls/actions/runs/1399127533
invalid value workflow reference: no version specified
MrChocolatine
commented
Oct 29, 2021
Comment on lines
+10
to
+13
| concurrency: | ||
| group: ci-${{ github.head_ref || github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
This part cannot be moved in the reusable workflow (not supported yet), otherwise we get the error:
https://github.com/peopledoc/ember-feature-controls/actions/runs/1399155003
The workflow is not valid. peopledoc/ember-feature-controls/.github/workflows/org-ci.yml@ci-revamp-gh-actions (Line: 17, Col: 1): Concurrency is not yet supported at the root of a called workflow file
It must be declared in the caller workflow.
But it will be possible very soon, once this feature moves out of beta!
The following limitations will be removed when workflow reuse moves out of beta:
You can't set theconcurrencyof a called workflow from the caller workflow.
MrChocolatine
changed the title
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
8 times, most recently
from
ab77014
to
181d387
Compare
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
from
3877353
to
c2edf28
Compare
MrChocolatine
changed the title
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
2 times, most recently
from
7dfc022
to
88dd395
Compare
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
4 times, most recently
from
9b3a3ed
to
e944315
Compare
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
from
e944315
to
25ff038
Compare
GreatWizard
approved these changes
Nov 2, 2021
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
5 times, most recently
from
ce257ad
to
962fa9b
Compare
`ember-get-config`, latest version 0.5.0, doesn't support Embroider yet as this PR has not been merged as the time of writing this commit: mansona/ember-get-config#29 In parallel, Embroider tests scenarios fail on our side: https://github.com/peopledoc/ember-feature-controls/actions/runs/1408588177 | `--> Relates to this issue: embroider-build/embroider#823 This issue 823 recommends to use `require('@embroider/compat').compatBuild` in order to disable Embroider's adapter `ember-get-config` (see also https://github.com/embroider-build/embroider/tree/v0.47.1#options). But it does not work: `app` is not accepted by `compatBuild()` because it is an `EmberAddon`, not an `EmberApp`. Log from the error: ``` Argument of type 'EmberAddon' is not assignable to parameter of type 'EmberAppInstance'. Property 'testIndex' is missing in type 'EmberAddon' but required in type 'EmberAppInstance'.ts(2345) ``` However, the following document indicates we can pass these options to `maybeEmbroider()` to configure Embroider: https://github.com/embroider-build/embroider/tree/v0.47.1/packages/test-setup#maybeembroiderapp-embroideroptions References: - Embroider's adapter for `ember-get-config`: https://github.com/embroider-build/embroider/blob/v0.47.1/packages/compat/src/compat-adapters/ember-get-config.ts - Embroider compatibility options: https://github.com/embroider-build/embroider/blob/v0.47.1/packages/compat/src/options.ts#L46-L61 - Discussions on Discord where I first saw the same initial issue: - https://discordapp.com/channels/480462759797063690/568935504288940056/901170716949512233 - https://discordapp.com/channels/480462759797063690/568935504288940056/902484167915364433
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
from
9c3a1f6
to
d0ae990
Compare
MrChocolatine
force-pushed
the
ci-revamp-gh-actions
branch
from
d0ae990
to
b1137e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Update
@embroider/test-setupto v0.47.1 (#160)Disable Embroider's compatibility adapter for
ember-get-config(#160)See the dedicated commit for extensive details about these changes.
Deduplicate packages (#160)
See https://github.com/atlassian/yarn-deduplicate.
CI
Reuse organisation's workflow to run lint & tests (#160)
This change also activates the tests for Embroider.
Reuse organisation's workflow to run tag & publish (#160)