Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Run all ember-try scenarios despite failure #156

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Conversation

MrChocolatine
Copy link
Member

@MrChocolatine MrChocolatine commented Oct 25, 2021

CI

Run all ember-try scenarios despite failure (#156)

See ember-cli/ember-cli#9661 :

The existing configs use fail-fast or fast_finish to abort builds once one scenario has failed. However, because addon projects will often support multiple versions of Ember as well as use forward-looking testing for beta/canary versions to catch issues, we want to ensure that all scenarios get run even if one of them fail. This is especially important for the GitHub Actions workflow, which doesn't have a concept of "allowed failures". As such, it's quite common that a build such as ember-canary might fail but still be ok to merge, if all other scenarios pass. By setting this config to true, we could hit scenarios where an expected failure occurred and all other builds were automatically aborted, thus preventing maintainers from knowing if the other scenarios would pass.

Merge jobs lint and tests (#156)

These 2 sequential jobs were 95 % similar, the only difference being the last step: the lint and the test suite. This a waste of resources as they will instantiate a new runner.

Instead we run them in the same job/same runner, and because GitHub Actions steps are sequential too, the step for the tests suite will only run if the lint step is successful.

@MrChocolatine MrChocolatine added the ci Continuous Integration label Oct 25, 2021
@MrChocolatine MrChocolatine requested a review from a team as a code owner October 25, 2021 18:49
@MrChocolatine MrChocolatine marked this pull request as draft October 26, 2021 13:20
@MrChocolatine MrChocolatine marked this pull request as ready for review October 26, 2021 13:24
@MrChocolatine MrChocolatine changed the title ci: remove redundant option fail-fast: true CI - Run all ember-try scenarios despite failure) Oct 26, 2021
@MrChocolatine MrChocolatine changed the title CI - Run all ember-try scenarios despite failure) CI - Run all ember-try scenarios despite failure Oct 26, 2021
@MrChocolatine MrChocolatine changed the title CI - Run all ember-try scenarios despite failure CI - Run all ember-try scenarios despite failure Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants