Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
Bump
eslint-plugin-ember
from 10.5.5 to 10.5.7 (#150)Bump
@types/ember__object
from 3.12.5 to 3.12.6 (#151)CI
Replace test scenario
ember-lts-3.24
withember-lts-3.16
(#148)At the time of writing these changes, the add-on already runs with
[email protected]
so testing the LTS v3.24 in the CI does not make sense.Follow the native implementation of Ember.js:
Documentation
Lower compatible version of Ember.js (#148)
Because the CI will test against Ember.js v3.16, we should mention the add-on is compatible with this version.
Add a section about TypeScript support (#149)
Features
Allow to pass type of embedded options to Service
embedded
(#149)The Service
embedded
now accepts a generic type parameter to improve the accuracy of what it can return.Fixes
Fix required versions of Node.js (#148)
Node.js v10 is actually not supported so we should not mention it in our
package.json
.Refactor
Update Service
embedded
to native JS class (#149)Make tests of Service
embedded
stricter (#149)Prefer
assert.strictEqual()
overassert.equal()
.