-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update ember-try config, add embroider test scenarios #121
Conversation
7145c21
to
b840bda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have *.orig
files do we want to keep them? These files also have git-diff
syntax in them <<<<<<< HEAD
, I am not sure we want to keep that.
Is the PR finished 🤔 ?
Also, why removing the prefix ember-
from the test scenarios? It does not seem to bring any value here, also I thought it would be easier to have scenarios with a full name alongside Embroider scenarios named embroider-*
.
This has been a mistake, I have commit some files coming from the Idea
I removed the |
- Add `@embroider/test-setup` package and config - Remove Canary scenario from `ember-try` - Remove `ember-` prefix from ember-try configuration - Update Ember LTS versions in `ember-try`
9358e78
to
fa252a1
Compare
I see, I initially thought we wanted full names. |
CI
Update ember-try scenarios with Ember 3.24 LTS and Embroider tests (#121)
Remove
ember-
prefix from Github Actions configRemove Ember 3.16 LTS from ember-try testing
Remove
ember-canary
scenarioAdd Ember 3.24 LTS to ember-try testing
Add
@embroider/test-setup
to ember-tryThis update adds the
embroider-safe
andembroider-optimized
scenarios to ember-try. This gives the opportunity to check whether the addon is ready for Embroider or not.@embroider/test-setup