Avoid duplicate before-event reminders after offset changes

[FleetAdmiralJakob]

Motivation

• Prevent creating duplicate in-app "before-event" notifications when a user changes the reminderOffsetMinutes preference after a before-event notification has already been created.
• Keep on-device scheduled notification metadata aligned with Convex inbox de-duplication so preference edits still allow rescheduling without producing extra inbox items.

Description

• Use a stable per-entry before-event event key before:<entryId> in the Convex mutation syncDueNotifications and in local planner output so de-duplication ignores the reminder offset value.
• Update the local notification planner to emit key: "before:<entryId>" and adjust the local notification scheduler expectations to include the same stable key in scheduled notification data.dayovaNotificationKey.
• Add a regression test changing reminder offset does not duplicate an already-created before-event notification to convex/notifications.test.ts that asserts updating reminderOffsetMinutes does not create a second inbox notification.

Testing

• Ran unit tests with pnpm test src/lib/notification-planner.test.ts src/lib/local-notification-scheduler.test.ts convex/notifications.test.ts and all tests passed (3 files, 9 tests).
• Ran full checks with pnpm check (lint + tsc --noEmit) and the checks completed successfully.

---

Codex Task

Summary by CodeRabbit

• Bug Fixes

  • Fixed an issue where changing your reminder offset would create duplicate before-event notifications instead of updating the existing one.

• Tests

  • Added test coverage for notification deduplication when reminder preferences change.
  • Updated test expectations to reflect new notification key format.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9ad91dc-82c0-45d5-b47f-075dc4321c93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/github-mention-codex]-implement-local-notifications-and-in

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}