Skip to content

Commit

Permalink
Fix passed parameters, move load_ko_csv to common
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinlul committed Aug 10, 2023
1 parent 97441fe commit cd56f99
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 13 deletions.
11 changes: 11 additions & 0 deletions src/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,3 +295,14 @@ def write(obj: Any, basename: str, yaml: YAML, logger: logging.Logger) -> None:
logger.info(f"Write: {basename}.json")
with open(f"{basename}.json", mode="w", encoding="utf-8") as out:
json.dump(obj, out)


def load_ko_csv(key: str, filename: Optional[str]) -> Dict[int, Dict[str, str]] | None:
if not filename:
return
with open(filename, encoding="utf8") as f:
reader = DictReader(f)
return {
int(row[key]): row
for row in reader
}
4 changes: 3 additions & 1 deletion src/job_ocgtcg.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ruamel.yaml import YAML
from ruamel.yaml.scalarstring import LiteralScalarString

from common import annotate_shared, initial_parse, int_or_none, int_or_og, transform_image, transform_names, transform_sets, transform_texts, write
from common import annotate_shared, initial_parse, int_or_none, int_or_og, transform_image, transform_names, transform_sets, transform_texts, write, load_ko_csv

module_logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -221,6 +221,8 @@ def job(
assignments = load_assignments(yaml, assignment_file) if assignment_file else None
ko_overrides = load_ko_overrides(ko_file) if ko_file else None
ko_official = load_ko_official(ko_official_csv) if ko_official_csv else None
ko_override = load_ko_csv("konami_id", ko_override_csv)
ko_prerelease = load_ko_csv("yugipedia_page_id", ko_prerelease_csv)
results = []
for i, filename in enumerate(filenames):
filepath = os.path.join(wikitext_dir, filename)
Expand Down
13 changes: 1 addition & 12 deletions src/job_rush.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ruamel.yaml import YAML

from common import int_or_og, initial_parse, int_or_none, transform_names, transform_texts, annotate_shared, \
transform_sets, transform_image, transform_multilanguage, write
transform_sets, transform_image, transform_multilanguage, write, load_ko_csv

module_logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -54,17 +54,6 @@ def write_output(yaml: YAML, logger: logging.Logger, document: Dict[str, Any]) -
write(document, basename, yaml, logger)


def load_ko_csv(key: str, filename: Optional[str]) -> Dict[int, Dict[str, str]] | None:
if not filename:
return
with open(filename, encoding="utf8") as f:
reader = DictReader(f)
return {
int(row[key]): row
for row in reader
}


def job(
wikitext_dir: str,
filenames: List[str],
Expand Down
2 changes: 2 additions & 0 deletions src/main_ocgtcg.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def main() -> None:
ocg,
args.ko,
args.ko_official,
args.ko_override,
args.ko_prerelease,
args.aggregate is not None,
)
if processes == 1:
Expand Down

0 comments on commit cd56f99

Please sign in to comment.