Skip to content

Commit

Permalink
Bump Node.js to v20
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinlul committed Oct 29, 2023
1 parent 369503c commit 07c78d1
Show file tree
Hide file tree
Showing 5 changed files with 171 additions and 192 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: yarn
- run: yarn
- run: yarn build
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ARG NODE_VERSION=18-bullseye
# Not bookworm due to https://github.com/nodejs/node/issues/43064
ARG NODE_VERSION=20-bullseye
FROM node:${NODE_VERSION} as base
WORKDIR /app
COPY package*.json yarn.lock ./
Expand Down
19 changes: 10 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
],
"license": "AGPL-3.0-or-later",
"engines": {
"node": ">=18",
"node": ">=20",
"yarn": "1.22.x"
},
"dependencies": {
"@fast-csv/format": "^4.3.5",
"async-mutex": "^0.4.0",
"coveralls": "link:.vscode",
"coveralls": "link:./node_modules/.NULL",
"debug": "^4.3.4",
"discord.js": "^14.13.0",
"dotenv": "^16.3.1",
"jimp": "link:.vscode",
"jimp": "link:./node_modules/.NULL",
"make-fetch-happen": "^13.0.0",
"node-fetch": "^2.7.0",
"pg": "^8.11.3",
Expand All @@ -45,21 +45,22 @@
"ygopro-data": "1.4.1"
},
"devDependencies": {
"@alphakretin/essentials": "^5.1.0",
"@alphakretin/essentials": "^6.0.0",
"@alphakretin/mocha-ecosystem": "^1.1.0",
"@types/debug": "^4.1.10",
"@types/make-fetch-happen": "^10.0.3",
"@types/node-fetch": "^2.6.7",
"testcontainers": "^9.12.0"
},
"resolutions": {
"@types/node": "^18.18.6",
"coveralls": "link:.vscode",
"jimp": "link:.vscode",
"@types/node": "^20.8.9",
"better-sqlite3": "^9.0.0",
"coveralls": "link:./node_modules/.NULL",
"jimp": "link:./node_modules/.NULL",
"string-width": "^4.2.3",
"strip-ansi": "^6.0.1",
"undici": "^5.26.4",
"wrap-ansi": "^6.2.0"
"undici": "^5.27.0",
"wrap-ansi": "^7.0.0"
},
"eslintConfig": {
"extends": "@alphakretin"
Expand Down
3 changes: 3 additions & 0 deletions test/events/messageCreate.unit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ const participantRole = new ParticipantRoleProvider(mockBotClient);
let container: StartedPostgreSqlContainer;

describe("Direct message submissions", function () {
let clock: sinon.SinonFakeTimers;
before(async () => {
clock = sinon.useFakeTimers();
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
decks = await initializeDeckManager(process.env.OCTOKIT_TOKEN!);
container = await new PostgreSqlContainer("postgres:13-alpine").start();
Expand All @@ -58,6 +60,7 @@ describe("Direct message submissions", function () {
after(async () => {
await getConnection().destroy();
await container.stop();
clock.restore();
});

// TODO: test attachment version
Expand Down
Loading

0 comments on commit 07c78d1

Please sign in to comment.