gem broken on (recent) JRuby due ext loading #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…covery ... expected to work on old JRubies as well as recent 1.7.x and 9K (which are broken otherwise)
| @@ -22,4 +22,3 @@ def parse_pg_array(value) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the loading mechanism currently used was cumbersome and does not work anymore.
... and wasn't really documented much so its surprising someone come up with it :)
JRuby did not run into any other users using it and would be for the best if it was avoided.
recenlty one of our users reported issues requiring
pg_array_parserunder a recent JRuby 1.7.xjruby/jruby#3601 ... thus please push a new gem version for us, thanks
please note that the gem as is also not working on JRuby 9K
beyond the PR there's an additional commit to test things under JRuby: https://travis-ci.org/kares/pg_array_parser/builds/103333746