Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that since Ember 2.3.1 (unreleased) this addon is not needed anymore #28

Closed
cibernox opened this issue Feb 3, 2016 · 4 comments · Fixed by #79
Closed

Document that since Ember 2.3.1 (unreleased) this addon is not needed anymore #28

cibernox opened this issue Feb 3, 2016 · 4 comments · Fixed by #79

Comments

@cibernox
Copy link
Contributor

cibernox commented Feb 3, 2016

Since emberjs/ember.js#12877 the cursor position issue is handled by HTMLBars itself, so we can use regular inputs with no problem. It's more verbose but also much faster.

That will probably make this component less needed. Perhaps there is some use case I'm not aware where you want this component over a native <input> tag.

More concise syntax?

@poteto
Copy link
Collaborator

poteto commented Feb 3, 2016

That is correct, however this addon still remains useful as a wrapper on top of the regular native input, for example having a sanitization method. We are also going to implement other controls in this addon (not just the input)

@rwjblue
Copy link
Contributor

rwjblue commented Feb 3, 2016

I was thinking this addon could automatically rewrite {{one-way-input into the appropriate plain HTML version. Lets us provide a super nice consitent API across Ember versions and removes the need for a component at all (read MUCH FASTER)...

@courajs
Copy link
Contributor

courajs commented Feb 5, 2016

@rwjblue you mean by hooking into the build pipeline?

@ghost
Copy link

ghost commented Apr 15, 2016

@rwjblue When you have time could you outline how that would work?

ghost pushed a commit that referenced this issue Apr 17, 2016
- Added short demo for all controls
- Added note that the cursor jumping bug has been fixed in Ember 2.3.1 (Closed #28)
@ghost ghost mentioned this issue Apr 17, 2016
homu added a commit that referenced this issue Apr 17, 2016
Update the README

- Added short demo for all controls
- Added note that the cursor jumping bug has been fixed in Ember 2.3.1 (Closes #28)
homu added a commit that referenced this issue Apr 17, 2016
Update the README

- Added short demo for all controls
- Added note that the cursor jumping bug has been fixed in Ember 2.3.1 (Closes #28)
@homu homu closed this as completed in #79 Apr 17, 2016
@ghost ghost mentioned this issue Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants