Change getRemovedComponent to return readonly component

DavidPeicho · Aug 2, 2020 · 6d8bdc2 · 6d8bdc2
1 parent 5fefe49
commit 6d8bdc2
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 2 deletions.
diff --git a/src/Entity.d.ts b/src/Entity.d.ts
@@ -29,7 +29,7 @@ export class Entity {
    */
   getRemovedComponent<C extends Component<any>>(
       Component: ComponentConstructor<C>
-  ): C;
+  ): Readonly<C> | undefined;
 
   /**
    * Get an object containing all the components on this entity, where the object keys are the component types.

diff --git a/src/Entity.js b/src/Entity.js
@@ -43,7 +43,11 @@ export class Entity {
   }
 
   getRemovedComponent(Component) {
-    return this._componentsToRemove[Component._typeId];
+    const component = this._componentsToRemove[Component._typeId];
+
+    return process.env.NODE_ENV !== "production"
+      ? wrapImmutableComponent(Component, component)
+      : component;
   }
 
   getComponents() {

diff --git a/test/unit/entity.test.js b/test/unit/entity.test.js
@@ -241,6 +241,40 @@ test("get component production", async t => {
   process.env.NODE_ENV = oldNodeEnv;
 });
 
+test("get removed component development", async t => {
+  var world = new World();
+
+  world.registerComponent(FooComponent);
+
+  // Sync
+  var entity = world.createEntity();
+  entity.addComponent(FooComponent);
+  entity.removeComponent(FooComponent);
+
+  const component = entity.getRemovedComponent(FooComponent);
+
+  t.throws(() => (component.variableFoo = 4));
+});
+
+test("get removed component production", async t => {
+  const oldNodeEnv = process.env.NODE_ENV;
+  process.env.NODE_ENV = "production";
+  var world = new World();
+
+  world.registerComponent(FooComponent);
+
+  // Sync
+  var entity = world.createEntity();
+  entity.addComponent(FooComponent);
+  entity.removeComponent(FooComponent);
+
+  const component = entity.getRemovedComponent(FooComponent);
+
+  t.notThrows(() => (component.variableFoo = 4));
+
+  process.env.NODE_ENV = oldNodeEnv;
+});
+
 test("get mutable component", async t => {
   var world = new World();