fix: Resolve Hyva theme installation in interactive installer#1
Merged
DavidLambauer merged 1 commit intoDavidLambauer:feature/interactive-installerfrom Apr 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR fixes Hyva theme installation in the interactive installer introduced by PR mage-os#191.
Three bugs were identified during manual testing that prevented the Hyva theme from being
applied after installation:
ThemeConfigurationVO dropped Hyva credentials —hyva_project_keyandhyva_api_tokenwere collected during the theme config stage but never stored in theValue Object, causing
ThemeInstallerto always receive empty credentials and abortwith "Hyva credentials are required".
theme:listis not a valid Magento CLI command —ThemeConfigurer::getThemeId()called
bin/magento theme:listwhich does not exist, causing theme application tosilently fail for all non-Luma themes. Replaced with a direct PDO query against the
themetable, following the same pattern already used inDatabaseValidator.Hyva API token excluded from
toArray()output —ThemeInstallationStagecalled$theme->toArray()without the$includeSensitiveflag, so the API token was neverpassed to
HyvaInstaller.Related Pull Requests
Fixed Issues (if relevant)
No dedicated issue — bugs were found during manual testing of PR mage-os#191.
Manual testing scenarios (*)
env.php, empty database)bin/magento install(Repo URL format:
https://hyva-themes.repo.packagist.com/{project-key}/)in the post-install output
Contribution checklist (*)
Note: I left the two checklist items unchecked — unit tests for the PDO-based getThemeId() weren't added in this session, and CI hasn't run yet on your fork.