Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ToQuotes for HeikinAshi #873

Merged
merged 1 commit into from
Aug 21, 2022
Merged

.ToQuotes for HeikinAshi #873

merged 1 commit into from
Aug 21, 2022

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Aug 21, 2022

Description

Minor utility for Heikin-Ashi, for anyone who wants to convert class types to a Quote list (optional). Since HeikinAshiResult is based on IQuote, this conversion is unnecessary since results from Heikin-Ashi can be used to directly replace normal quotes on all indicators. However, some users may simply want it in Quote syntax.

IEnumerable<Quote> results = quotes.GetHeikinAshi().ToQuotes();

Implements #872

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender marked this pull request as ready for review August 21, 2022 01:12
@DaveSkender DaveSkender merged commit de15884 into main Aug 21, 2022
@DaveSkender DaveSkender deleted the hktoquotes branch August 21, 2022 01:16
@DaveSkender DaveSkender mentioned this pull request Aug 23, 2022
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant