Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SMMA to MA Envelopes #617

Merged
merged 2 commits into from
Nov 13, 2021
Merged

add SMMA to MA Envelopes #617

merged 2 commits into from
Nov 13, 2021

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Nov 13, 2021

Description

Adding SMMA to MA Envelopes selection options.

To do:

  • investigate options to reduce code complexity

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage
  • I have added or run the performance tests that depict optimal execution times
  • New and existing unit tests pass locally and in the build (below) with my changes

@DaveSkender DaveSkender merged commit 6b0543b into main Nov 13, 2021
@DaveSkender DaveSkender deleted the smma-maenv branch November 13, 2021 21:29
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant