refactor: Naming standardization #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 6 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
- src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (2)
src/a-d/Atr/Atr.StreamHub.cs:75
- [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);
src/s-z/Tr/Tr.StreamHub.cs:54
- [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
int i = indexHint ?? ProviderCache.IndexOf(item, true);
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 9 out of 23 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- src/Indicators.csproj: Language not supported
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- tests/indicators/m-r/ParabolicSar/ParabolicSar.StaticSeries.Tests.cs: Evaluated as low risk
- src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- tests/indicators/_common/Observables/StreamHub.Utilities.Tests.cs: Evaluated as low risk
- src/_common/ObsoleteV3.cs: Evaluated as low risk
- src/s-z/StdDevChannels/StdDevChannels.StaticSeries.cs: Evaluated as low risk
- src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
- src/a-d/AtrStop/AtrStop.StreamHub.cs: Evaluated as low risk
- tests/indicators/e-k/Kvo/Kvo.StaticSeries.Tests.cs: Evaluated as low risk
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
* Add `[Obsolete]` attribute to `Quote` class's `Date` property in `src/_common/Quotes/Quote.Models.cs` * Add `PublicApi.Obsolete.Tests.cs` file with test coverage for deprecated features from v2 * Update `src/_common/ObsoleteV3.md` with deprecated and breaking changes summary
There was a problem hiding this comment.
Copilot reviewed 32 out of 46 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- .editorconfig: Language not supported
- src/Directory.Packages.props: Language not supported
- src/Indicators.csproj: Language not supported
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/_common/ObsoleteV3.cs: Evaluated as low risk
- src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
- src/_common/Observables/StreamHub.Utilities.cs: Evaluated as low risk
- src/a-d/Atr/Atr.StreamHub.cs: Evaluated as low risk
- src/_common/Quotes/Quote.Models.cs: Evaluated as low risk
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Adx/Adx.BufferList.cs: Evaluated as low risk
- src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/_common/Quotes/Quote.StreamHub.cs:50
- [nitpick] The method name 'IndexGte' might be unclear. Consider renaming it to 'GetIndexGte' for better clarity.
?? Cache.IndexGte(item.Timestamp);
There was a problem hiding this comment.
Copilot reviewed 33 out of 47 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- .editorconfig: Language not supported
- src/Directory.Packages.props: Language not supported
- src/Indicators.csproj: Language not supported
- src/a-d/Adx/Adx.BufferList.cs: Evaluated as low risk
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/s-z/Sma/Sma.StreamHub.cs: Evaluated as low risk
- src/m-r/RenkoAtr/RenkoAtr.StaticSeries.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- src/_common/Quotes/Quote.StreamHub.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
- src/_common/ObsoleteV3.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/a-d/Atr/Atr.StreamHub.cs:75
- [nitpick] The method
IndexOfis correctly renamed fromGetIndex. However, the method's name should be consistent with the other methods in the same file, which use theIndexGtenaming convention.
int i = indexHint ?? ProviderCache.IndexOf(item, true);
There was a problem hiding this comment.
Copilot reviewed 36 out of 50 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- .editorconfig: Language not supported
- src/Directory.Packages.props: Language not supported
- src/Indicators.csproj: Language not supported
- src/_common/Reusable/Reusable.Utilities.cs: Evaluated as low risk
- src/_common/ObsoleteV3.cs: Evaluated as low risk
- src/a-d/Adl/Adl.StreamHub.cs: Evaluated as low risk
- src/_common/Quotes/Quote.Models.cs: Evaluated as low risk
- src/_common/Quotes/Quote.StreamHub.cs: Evaluated as low risk
- src/_common/Observables/StreamHub.cs: Evaluated as low risk
- src/a-d/Adx/Adx.BufferList.cs: Evaluated as low risk
- src/m-r/ParabolicSar/ParabolicSar.StaticSeries.cs: Evaluated as low risk
- src/a-d/Alligator/Alligator.StreamHub.cs: Evaluated as low risk
- src/m-r/Renko/Renko.StreamHub.cs: Evaluated as low risk
- src/e-k/Ema/Ema.StreamHub.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/_common/ObsoleteV3.md:18
- The word 'innaccurately' is misspelled. It should be 'inaccurately'.
The former "Get" prefix innaccurately implied a retrieval operation.
* Add a summary of all technical changes to the public API. * Enumerate the exact syntax changes. * Provide a detailed and clear migration path. * Include specific examples of deprecated and breaking changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done when
GetIndexutility methodsGetEma()toToEma()